Bug 483817
Summary: | re-implement /usr/bin/fedora-setup-keyboard in C to speed up boot | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> |
Component: | xorg-x11-server | Assignee: | Peter Hutterer <peter.hutterer> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | harald, kad, peter.hutterer, petersen, xgl-maint |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-04 01:50:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 486698 | ||
Bug Blocks: |
Description
Adel Gadllah
2009-02-03 18:43:49 UTC
At least one logical problem exists: if(!libhal_ctx_set_dbus_connection(hal_ctx, dbus_bus_get(DBUS_BUS_SYSTEM, NULL))) you should be using direct hal connection instead of system bus if it's requested by hal. (look at hal-set-property code for option --direct) Second, having keyboards statically inserted in the code, not the best idea. If it's worth to change, this DB should be split into separate file and used by both, system-config-keyboard and fedora-setup-keyboard. (In reply to comment #1) > At least one logical problem exists: > if(!libhal_ctx_set_dbus_connection(hal_ctx, dbus_bus_get(DBUS_BUS_SYSTEM, > NULL))) > > you should be using direct hal connection instead of system bus if it's > requested by hal. > (look at hal-set-property code for option --direct) OK, fixed this in a new version. (uploaded to same location) > Second, having keyboards statically inserted in the code, not the best idea. > If it's worth to change, this DB should be split into separate file and used by > both, system-config-keyboard and fedora-setup-keyboard. I agree with that, but it was static content in the rhpl source before, if someone pushes it out of rhpl to a generic database we can use it here too. dbus-c++-0.5.0-0.4.20090203git13281b3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dbus-c++'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1407 dbus-c++-0.5.0-0.4.20090203git13281b3.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update dbus-c++'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1430 Just ignore the dbus-c++ messages, typed the wrong bug number in bodhi. *** Bug 478431 has been marked as a duplicate of this bug. *** > Second, having keyboards statically inserted in the code, not the best idea.
> If it's worth to change, this DB should be split into separate file and used by
> both, system-config-keyboard and fedora-setup-keyboard.
rhpl / system-config-keyboard stores all options (rather than just the layout name) in /etc/sysconfig/keyboard starting with F10, so the static database will only be used for legacy configs (people upgraded from older releases).
Adel: sorry about the delay, didn't get to review it until now. Can you please put this as a new project on fedorahosted.org and we can then ship it as a separate package, with the X server depending on it. (In reply to comment #8) > Adel: > sorry about the delay, didn't get to review it until now. Can you please put > this as a new project on fedorahosted.org and we can then ship it as a separate > package, with the X server depending on it. OK, I filled an infrastructure ticket to create a new project on fedorahosted. (In reply to comment #8) > Adel: > sorry about the delay, didn't get to review it until now. Can you please put > this as a new project on fedorahosted.org and we can then ship it as a separate > package, with the X server depending on it. Review request for the separate package: https://bugzilla.redhat.com/show_bug.cgi?id=486698 xorg-x11-server-1.6.0-5 now requires the fedora-setup-keyboard package. |