Bug 484547

Summary:

Review Request: pyfacebook - Python wrapper for Facebook's API

Product:

[Fedora] Fedora

Reporter:

Ian Weller <ian>

Component:

Package Review

Assignee:

Conrad Meyer <cse.cem+redhatbugz>

Status:

CLOSED RAWHIDE

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

cse.cem+redhatbugz, fedora-package-review, notting

Target Milestone:

---

Flags:

cse.cem+redhatbugz: fedora-review+
kevin: fedora-cvs+

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2009-06-26 14:47:47 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

484548

Attachments:

Description	Flags
Review	none

Description Ian Weller 2009-02-08 08:45:06 UTC

Spec URL: http://ianweller.fedorapeople.org/SRPMS/pyfacebook/0.1-1.20090208svn173/pyfacebook.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/pyfacebook/0.1-1.20090208svn173/pyfacebook-0.1-1.20090208svn173.fc10.src.rpm

Description:
PyFacebook is a thin wrapper for accessing Facebook's RESTful API through
Python.

Comment 1 Conrad Meyer 2009-02-12 07:58:49 UTC

Created attachment 331664 [details]
Review

Initial review.

Comment 2 Ian Weller 2009-02-12 16:48:28 UTC

> - [ BAD ] MUST: The package must meet the Packaging Guidelines.

> http://wiki.developers.facebook.com/index.php/Python says there has not
> yet been a release. The Version should be 0 and Release should follow
> the pre-release guidelines:
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages

However, a version is given with the package, and this version is used in the Python egg distributed with the package.

http://code.google.com/p/pyfacebook/source/browse/trunk/setup.py#6

Comment 3 Conrad Meyer 2009-02-13 01:00:45 UTC

(In reply to comment #2)
> However, a version is given with the package, and this version is used in the
> Python egg distributed with the package.
> 
> http://code.google.com/p/pyfacebook/source/browse/trunk/setup.py#6

Then the version is ok. You still need to follow the pre-release guidelines and use a 0.X release tag.

Comment 4 Ian Weller 2009-03-08 22:08:41 UTC

ping?

Comment 5 Conrad Meyer 2009-03-08 22:14:31 UTC

Have you updated your spec to follow the pre-release naming guidelines (or has upstream released a stable version)? If so, please post URLs to the updated spec.

Comment 6 Ian Weller 2009-03-08 22:30:56 UTC

spec and SRPM in http://ianweller.fedorapeople.org/SRPMS/pyfacebook/0.1-0.1.20090208svn173/

Comment 7 Conrad Meyer 2009-03-08 22:42:20 UTC

Looks good, APPROVED. Thanks for packaging this :).

Comment 8 Ian Weller 2009-03-08 23:38:03 UTC

New Package CVS Request
=======================
Package Name: pyfacebook
Short Description: Python wrapper for Facebook's API
Owners: ianweller
Branches: F-10 EL-5

Comment 9 Ian Weller 2009-03-08 23:38:36 UTC

oh and of course -- thanks, conrad :)

Comment 10 Kevin Fenzi 2009-03-09 15:52:27 UTC

cvs done.

Comment 11 Ian Weller 2009-03-09 20:08:29 UTC

thanks kevin :)

Comment 12 Conrad Meyer 2009-03-21 00:05:41 UTC

Once you've imported and built this in rawhide, feel free to close this bug as CLOSED RAWHIDE :).