Bug 487190

Summary:	virt-manager has hardcoded Requires: PolicyKit-gnome
Product:	[Fedora] Fedora	Reporter:	Kevin Kofler <kevin>
Component:	virt-manager	Assignee:	Daniel Berrangé <berrange>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	berrange, crobinso, hbrock, markmc, quintela, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-04 23:36:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	480594, 487188

Description Kevin Kofler 2009-02-24 18:00:14 UTC

Description of problem:
virt-manager has a hardcoded dependency on PolicyKit-gnome. Is this really necessary? In the KDE spin, we would like to ship PolicyKit-kde instead of PolicyKit-gnome. PolicyKit-kde also implements the org.freedesktop.PolicyKit.AuthenticationAgent service.

(Note that virt-manager is not included on the current KDE spin.)

Version-Release number of selected component (if applicable):
virt-manager-0:0.6.1-2.fc11

How reproducible:
Always

Steps to Reproduce:
1. repoquery --repoid=rawhide --whatrequires PolicyKit-gnome
  
Actual results:
virt-manager requires PolicyKit-gnome.

Expected results:
virt-manager does not require PolicyKit-gnome.

Additional info:
Maybe a common Provides in both PolicyKit-gnome and PolicyKit-kde is needed?

Comment 1 Mark McLoughlin 2009-02-25 09:18:23 UTC

Looks to me like we can just require PolicyKit >= 0.7:

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/file/8176c489cd55/src/virtManager/connection.py#l309

i.e. since PolicyKit 0.7 we use org.freedesktop.PolicyKit.AuthenticationAgent which can be implemented by either PolicyKit-gnome or PolicyKit-kde, rather than directly using org.gnome.PolicyKit

Comment 2 Daniel Berrangé 2009-02-25 11:06:49 UTC

Yeah, there's no reason for us to depend on PolicyKit-gnome directly anymore in Fedora.

Comment 3 Kevin Kofler 2009-02-27 17:23:57 UTC

In Rawhide, both PolicyKit-gnome and PolicyKit-kde now have:
Provides: PolicyKit-authentication-agent
so you can require this instead of PolicyKit-gnome.

Comment 4 Cole Robinson 2009-03-04 23:36:39 UTC

Okay, this is in virt-manager-0.6.1-4.fc11. Closing