Bug 487263

Summary:	Review request: preferences-menus - Categorized submenus for the Preferences menu
Product:	[Fedora] Fedora	Reporter:	Matthias Clasen <mclasen>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	mclasen: fedora_requires_release_note+ panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-04 05:11:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Matthias Clasen 2009-02-25 05:51:37 UTC

Spec URL: http://people.redhat.com/mclasen/preferences-menus.spec
SRPM URL: http://people.redhat.com/mclasen/preferences-menus-1-1.fc11.src.rpm

Description:

This package recreates the Preferences submenus that Fedora used to have
by default in F10 and earlier.

Comment 1 Parag AN(पराग) 2009-02-25 06:19:03 UTC

1) Good to add versioned requires

2) From http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream , 
    Will you please add comment in SPEC file. Otherwise I see no way to verify source here.

3) From review guidelines,
   SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.

4) Though for such small package where no upstream release happened, it looks not really needed but good to follow guidelines
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps
==> Add -p to install command

Comment 2 Matthias Clasen 2009-02-25 14:43:30 UTC

I've added the versioned requires, add a comment and even did the -p.

Then, I've queried upstream (myself), but upstream said no.

New files in the same location.

Comment 3 Matthias Clasen 2009-02-26 03:13:47 UTC

We should probably release-note this:

The Preferences menu does no longer have submenus. This change was done since deep menu hierarchies are difficult to navigate for many users, and the category-based submenus were not terribly obvious. If you are used to the submenus, and prefer to keep the Peferences menu organized in this way, install the preferences-menus package.

Comment 4 Parag AN(पराग) 2009-02-26 03:41:03 UTC

(In reply to comment #2)
> I've added the versioned requires, add a comment and even did the -p.
> 
OK.

> Then, I've queried upstream (myself), but upstream said no.
 Nice comment.

> 
> New files in the same location.

thanks.

koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1182091
+ rpmlint is Not silent but ok to accept.
preferences-menus.noarch: W: no-documentation
preferences-menus.noarch: W: no-url-tag
+ Rest looks following packaging guidelines.

APPROVED.

Comment 5 Matthias Clasen 2009-02-26 04:42:42 UTC

New Package CVS Request
=======================
Package Name: preferences-menus 
Short Description: Categorized submenus for the Preferences menu
Owners: mclasen
Branches: 
InitialCC:

Comment 6 Kevin Fenzi 2009-02-27 00:09:39 UTC

cvs done.

Comment 7 Parag AN(पराग) 2009-03-04 05:11:18 UTC

looks this package is already built for requested branches therefore closing this review now.