Spec URL: http://people.redhat.com/mclasen/preferences-menus.spec SRPM URL: http://people.redhat.com/mclasen/preferences-menus-1-1.fc11.src.rpm Description: This package recreates the Preferences submenus that Fedora used to have by default in F10 and earlier.
1) Good to add versioned requires 2) From http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream , Will you please add comment in SPEC file. Otherwise I see no way to verify source here. 3) From review guidelines, SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. 4) Though for such small package where no upstream release happened, it looks not really needed but good to follow guidelines http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps ==> Add -p to install command
I've added the versioned requires, add a comment and even did the -p. Then, I've queried upstream (myself), but upstream said no. New files in the same location.
We should probably release-note this: The Preferences menu does no longer have submenus. This change was done since deep menu hierarchies are difficult to navigate for many users, and the category-based submenus were not terribly obvious. If you are used to the submenus, and prefer to keep the Peferences menu organized in this way, install the preferences-menus package.
(In reply to comment #2) > I've added the versioned requires, add a comment and even did the -p. > OK. > Then, I've queried upstream (myself), but upstream said no. Nice comment. > > New files in the same location. thanks. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1182091 + rpmlint is Not silent but ok to accept. preferences-menus.noarch: W: no-documentation preferences-menus.noarch: W: no-url-tag + Rest looks following packaging guidelines. APPROVED.
New Package CVS Request ======================= Package Name: preferences-menus Short Description: Categorized submenus for the Preferences menu Owners: mclasen Branches: InitialCC:
cvs done.
looks this package is already built for requested branches therefore closing this review now.