Bug 487818 (perl-Task-Catalyst)

Summary: Review Request: perl-Task-Catalyst - All you need to start with Catalyst
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Task-Catalyst
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-01 08:17:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chris Weyl 2009-02-28 01:22:41 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Task-Catalyst.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Task-Catalyst-3.0000-1.fc10.src.rpm

Description:
This package ensures everything you need to write serious Catalyst
applications is installed.  Install this if you're interested in
developing Catalyst apps.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1207555

*rt-0.05

Comment 1 Parag AN(पराग) 2009-02-28 02:49:03 UTC
Review:
+ package builds in mock (rawhide i386).
koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=1207555
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7a1dbc782dd2cc4e23c3ee0fde6e555f  Task-Catalyst-3.0000.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=3, Tests=3,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.12 cusr  0.02 csys =  0.17 CPU)
+ Package  perl-Task-Catalyst-3.0000-1.fc11-noarch ->
  Provides: perl(Task::Catalyst) = 3.0000
  Requires: perl(strict) perl(warnings)

 APPROVED.

Comment 2 Chris Weyl 2009-02-28 06:03:36 UTC
New Package CVS Request
=======================
Package Name: perl-Task-Catalyst
Short Description: All you need to start with Catalyst
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-03-01 00:24:48 UTC
cvs done.

Comment 4 Chris Weyl 2009-03-01 08:17:57 UTC
Thanks for the review! :-)