Spec URL: http://fedorapeople.org/~cweyl/review/perl-Task-Catalyst.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Task-Catalyst-3.0000-1.fc10.src.rpm Description: This package ensures everything you need to write serious Catalyst applications is installed. Install this if you're interested in developing Catalyst apps. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1207555 *rt-0.05
Review: + package builds in mock (rawhide i386). koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=1207555 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7a1dbc782dd2cc4e23c3ee0fde6e555f Task-Catalyst-3.0000.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=3, Tests=3, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.12 cusr 0.02 csys = 0.17 CPU) + Package perl-Task-Catalyst-3.0000-1.fc11-noarch -> Provides: perl(Task::Catalyst) = 3.0000 Requires: perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Task-Catalyst Short Description: All you need to start with Catalyst Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)