Bug 488099

Summary:	Review Request: python-polib - A library to parse and manage gettext catalogs
Product:	[Fedora] Fedora	Reporter:	Ignacio Vazquez-Abrams <ivazqueznet>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-23 05:05:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	488151, 488963

Description Ignacio Vazquez-Abrams 2009-03-02 17:53:42 UTC

Spec URL: http://ivazquez.fedorapeople.org/packages/python-polib/python-polib.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/python-polib/python-polib-0.4.0-1.20080217svnr60.src.rpm
Description: polib allows you to manipulate, create, modify gettext files (pot, po and mo files). You can load existing files, iterate through it's entries, add, modify entries, comments or metadata, etc... or create new po files from scratch.

polib provides a simple and pythonic API, exporting only three convenience functions 'pofile', 'mofile' and 'detect_encoding', and the 4 core classes: POFile, MOFile, POEntry and MOEntry for creating new files/entries.

Comment 1 Parag AN(पराग) 2009-03-03 06:56:26 UTC

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216017
+ rpmlint is silent for SRPM
+ rpmlint is NOT silent for RPM.
python-polib.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/polib.py 0644
==> can be ignored.
+ source files in tarball match upstream but as this is svn checkout unable to verify md5sum.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestions:
1)  use %global instead %define

APPROVED.

Comment 2 Ignacio Vazquez-Abrams 2009-03-03 09:32:16 UTC

New Package CVS Request
=======================
Package Name: python-polib
Short Description: A library to parse and manage gettext catalogs
Owners: ivazquez
Branches: F-9 F-10 EL-5
InitialCC: i18n-team

Comment 3 Kevin Fenzi 2009-03-03 20:41:37 UTC

cvs done.

Comment 4 Parag AN(पराग) 2009-03-23 04:56:24 UTC

If this package is built for all requested branches then can we have this review closed now?