Bug 488103
| Summary: | Review Request: django-evolution - Schema evolution for Django | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mail, michel, notting |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-23 05:06:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 487097, 488151, 488963 | ||
|
Description
Ignacio Vazquez-Abrams
2009-03-02 18:03:27 UTC
The release number should probably be 0.x.prereleasedetails ? http://fedoraproject.org/wiki/Packaging/NamingGuidelines#NonNumericRelease I'd suggest 0.1.%{alphatag}%{?dist} -- the date is probably less important than the actual SVN revision. Almost ready -- everything is fine apart from the release number.
MUST
+ rpmlint: clean
+ package name: ok
+ spec file name
? package guideline-compliant
this should probably be 0.x.%{alphatag}%{?dist}
+ license complies with guidelines
+ license field accurate
+ license file not deleted
+ spec in US English
+ spec legible
+ source matches upstream
+ builds under >= 1 archs: noarch
+ build dependencies complete
+ own all directories
+ no dupes in %files
+ permission
+ %clean RPM_BUILD_ROOT
+ macros used consistently
+ Package contains code
+ large docs => -doc: not that large
+ clean buildroot before install
+ filenames UTF-8
SHOULD
- desc and summary contain translations if available
+ package build in mock on all architectures
+ package functioned as described
+ scriplets are sane
+ require package not files
Updated. http://ivazquez.fedorapeople.org/packages/django-evolution/django-evolution.spec http://ivazquez.fedorapeople.org/packages/django-evolution/django-evolution-0.0-0.1.svnr164.src.rpm Change looks good. APPROVED. Can you please go on with the CVS procedure? New Package CVS Request ======================= Package Name: django-evolution Short Description: Schema evolution for Django Owners: ivazquez Branches: F-9 F-10 EL-5 cvs done. |