Bug 488108

Summary: Review Request: django-tagging - A generic tagging application for Django projects
Product: [Fedora] Fedora Reporter: Ignacio Vazquez-Abrams <ivazqueznet>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-23 05:06:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 488151, 488963    

Description Ignacio Vazquez-Abrams 2009-03-02 18:13:43 UTC
Spec URL: http://ivazquez.fedorapeople.org/packages/django-tagging/django-tagging.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/django-tagging/django-tagging-0.3-1.20080217svnr154.src.rpm
Description: A generic tagging application for Django projects, which allows association of a number of tags with any Model instance and makes retrieval of tags simple.

Comment 1 Parag AN(पराग) 2009-03-03 08:05:06 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216130
+ rpmlint is silent for SRPM and for RPM.
+ files in source tarball match source packaged in srpm but no way to verify md5sum as source is svn checkout.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ egg file generated from source.

Suggestions:
1) I will suggest to use 
%doc CONTRIBUTORS.txt LICENSE.txt docs/*
will make not to create docs named directory
2) Change %define to %global

APPROVED.

Comment 2 Ignacio Vazquez-Abrams 2009-03-03 09:37:03 UTC
Package Name: django-tagging
Short Description: A generic tagging application for Django projects
Owners: ivazquez
Branches: F-9 F-10 EL-5

Comment 3 Kevin Fenzi 2009-03-03 20:44:18 UTC
cvs done.

Comment 4 Parag AN(पराग) 2009-03-23 04:55:48 UTC
If this package is built for all requested branches then can we have this review closed now?