Bug 488172
| Summary: | Package Review: ibus-table-zhengma | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caius Chance <K9> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CANTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, K9, notting, panemade, petersen, phuang |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | Flags: | panemade:
fedora-review-
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-07 03:47:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 488010 | ||
| Bug Blocks: | 484650 | ||
|
Description
Caius Chance
2009-03-03 00:03:30 UTC
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-zhengma-1.1.0.20090402-1.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-zhengma.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1274694 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 5981da2341988d13ebd0c6c01bcb047f ibus-table-zhengma-1.1.0.20090402.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + ibus-table-createdb scriptlet used. + file permissions are appropriate. + Not a GUI App. Suggestions: 1) check header of zhengma.txt table file. Can you confirm license with upstream if it really is GPLv3+? 2) try adding contents to Changelog file in upstream and add it as %doc Looks like patent problem here. Patent should be expired in DEC 09. |