Bug 488172 - Package Review: ibus-table-zhengma
Summary: Package Review: ibus-table-zhengma
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 488010
Blocks: 484650
TreeView+ depends on / blocked
 
Reported: 2009-03-03 00:03 UTC by Caius Chance
Modified: 2009-04-07 05:37 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-07 03:47:40 UTC
Type: ---
Embargoed:
panemade: fedora-review-


Attachments (Terms of Use)

Description Caius Chance 2009-03-03 00:03:30 UTC
A split from ibus-table-chinese, which was sub-package of ibus-table.

Uploading srpm and spec.

Comment 1 Caius Chance 2009-04-02 02:47:49 UTC
SRPM URL:
http://cchance.fedorapeople.org/packaging/ibus-table-zhengma-1.1.0.20090402-1.fc11.src.rpm
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-zhengma.spec
Description: A split from ibus-table-chinese, which was sub-package of ibus-table.

Comment 2 Parag AN(पराग) 2009-04-03 05:43:11 UTC
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1274694
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5981da2341988d13ebd0c6c01bcb047f  ibus-table-zhengma-1.1.0.20090402.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlet used.
+ file permissions are appropriate.
+ Not a GUI App.  

Suggestions:
1) check header of zhengma.txt table file. Can you confirm license with upstream if it really is GPLv3+?
2) try adding contents to Changelog file in upstream and add it as %doc

Comment 4 Parag AN(पराग) 2009-04-07 03:47:40 UTC
Looks like patent problem here.

Comment 5 Caius Chance 2009-04-07 05:37:22 UTC
Patent should be expired in DEC 09.


Note You need to log in before you can comment on or make changes to this bug.