Bug 488850

Summary:	devkit-disks --inhibit broken parameter handling
Product:	[Fedora] Fedora	Reporter:	Warren Togami <wtogami>
Component:	DeviceKit-disks	Assignee:	David Zeuthen <davidz>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	davidz, mclasen
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-17 00:52:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	446452

Description Warren Togami 2009-03-05 22:29:42 UTC

DeviceKit-003-1

Bug #488756 DeviceKit interferes with livecd-creator

It was suggested that "devkit-disks --inhibit" be used to prevent GNOME from mounting the temporary device mapper device that can cause livecd-creator to fail.

    devkit-disks --inhibit -- /bin/true
This succeeds.

    devkit-disks --inhibit -- /bin/true -foo
This fails with:
Error launching program: Failed to execute child process "--" (No such file or directory)

devkit-disks isn't handling parameters properly.

Comment 1 Matthias Clasen 2009-03-06 06:00:31 UTC

Here is the relevant quote from the g_option_context_parse() docs:

A '--' option is stripped from argv unless there are unparsed options before and after it, or some of the options after it start with '-'.

Comment 2 Matthias Clasen 2009-03-06 16:30:11 UTC

I've put a patch in our rpm. Leaving this bug open so David sees it when he returns.

Comment 3 Matthias Clasen 2009-03-16 20:23:05 UTC

David, do you want to move this patch upstream and close this bug ?

Comment 4 David Zeuthen 2009-03-17 00:52:02 UTC

Applied, thanks.

http://cgit.freedesktop.org/DeviceKit/DeviceKit-disks/commit/?id=7b9d4cac34d3beeecbfabe3964c70196f53cac8e