Bug 488850 - devkit-disks --inhibit broken parameter handling
Summary: devkit-disks --inhibit broken parameter handling
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: DeviceKit-disks
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: David Zeuthen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F11Blocker, F11FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2009-03-05 22:29 UTC by Warren Togami
Modified: 2009-03-17 00:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-03-17 00:52:02 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Warren Togami 2009-03-05 22:29:42 UTC 
DeviceKit-003-1

Bug #488756 DeviceKit interferes with livecd-creator

It was suggested that "devkit-disks --inhibit" be used to prevent GNOME from mounting the temporary device mapper device that can cause livecd-creator to fail.

    devkit-disks --inhibit -- /bin/true
This succeeds.

    devkit-disks --inhibit -- /bin/true -foo
This fails with:
Error launching program: Failed to execute child process "--" (No such file or directory)

devkit-disks isn't handling parameters properly.
Comment 1 Matthias Clasen 2009-03-06 06:00:31 UTC 
Here is the relevant quote from the g_option_context_parse() docs:

A '--' option is stripped from argv unless there are unparsed options before and after it, or some of the options after it start with '-'.
Comment 2 Matthias Clasen 2009-03-06 16:30:11 UTC 
I've put a patch in our rpm. Leaving this bug open so David sees it when he returns.
Comment 3 Matthias Clasen 2009-03-16 20:23:05 UTC 
David, do you want to move this patch upstream and close this bug ?
Comment 4 David Zeuthen 2009-03-17 00:52:02 UTC 
Applied, thanks.

http://cgit.freedesktop.org/DeviceKit/DeviceKit-disks/commit/?id=7b9d4cac34d3beeecbfabe3964c70196f53cac8e
Note You need to log in before you can comment on or make changes to this bug.