Bug 488908
| Summary: | Review Request: cpptest - A portable and powerful and simple unit testing framework for C++ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
| Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | bugs.michael, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bugs.michael:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.1.0-3.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-13 18:13:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 488512 | ||
|
Description
Rakesh Pandit
2009-03-06 05:54:14 UTC
$ rpmlint cpptest-1.1.0-1.fc10.src.rpm cpptest.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) * The pkg-config template file contains a hardcoded "/lib" in libdir. This won't work on 64-bit multi-arch platforms. Use libdir=@libdir@ instead. * The -devel package ought to "Requires: pkgconfig" since it places a file in %_libdir/pkgconfig/ (and there is no automatic dependency on all platforms). * Installation of documentation is messed up (upstream dist bug). All files in /usr/share/doc/cpptest-devel-1.1.0/images/ are included in ../html/ already. In "images/" they are misplaced and incomplete. * The %check section runs "make check", which is a no-op. The "test" target is built already during %build. If you run "cd test && make check", the tests fail: FailTestSuite: 2/2, 50% correct in 0.000017 seconds CompareTestSuite: 3/3, 33% correct in 0.000009 seconds ThrowTestSuite: 2/2, 50% correct in 0.000226 seconds Total: 7 tests, 42% correct in 0.000252 seconds SPEC: http://rakesh.fedorapeople.org/spec/cpptest.spec SRPM: http://rakesh.fedorapeople.org/srpm/cpptest-1.1.0-2.fc10.src.rpm Fixed all issues and reported testsuite failure to upstream. > reported testsuite failure to upstream.
What's the ticket number or URL? I cannot find a report in upstream's tracker.
[...]
I won't approve this package as long as this tiny test-suite fails as it uses libcpptest.
Yep .. very much test suite needs to be passed ... last to last week I seemed to have mistakenly reported in sf forum and not tracker http://sourceforge.net/forum/forum.php?thread_id=3110665&forum_id=264814 Reported it in tracker now: https://sourceforge.net/tracker/?func=detail&aid=2720762&group_id=77564&atid=550611 Thanks! Removed check section as it is not a test .. just an example. http://rakesh.fedorapeople.org/spec/cpptest.spec http://rakesh.fedorapeople.org/srpm/cpptest-1.1.0-3.fc10.src.rpm Had a chat with maintainer on IRC -- that it is not a test but an example and should fail, he has updated tracker also. http://sourceforge.net/tracker/?func=detail&atid=550611&aid=2720762&group_id=77564 Okay. That explains why the "test" target is built by default, but not run by "make check" unless one does "cd test ; make check". Reading mytest.cpp I'm convinced it's an example. Would have been nice if it tested its own test features and exceptions, oh well, ... :-) [...] APPROVED Thanks. New Package CVS Request ======================= Package Name: cpptest Short Description: A portable and powerful and simple unit testing framework for C++ Owners: rakesh Branches: F-9 F-10 InitialCC: Cvsextras Commits: yes cvs done. cpptest-1.1.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/cpptest-1.1.0-3.fc9 Imported in Rawhide. Will close for now .. in case problem comes .. will reopen! cpptest-1.1.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |