Bug 489293
Summary: | Review Request: kvkbd - Virtual keyboard for KDE | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jaroslav Reznik <jreznik> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-23 07:15:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jaroslav Reznik
2009-03-09 11:30:48 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1231229 I cannot build this on F10. cmake error CMake Error at /usr/share/cmake/Modules/FindKDE4.cmake:84 (MESSAGE): ERROR: cmake/modules/FindKDE4Internal.cmake not found in /root/.kde/share/apps;/usr/share/kde-settings/kde-profile/default/share/apps;/usr/share/kde4/apps Call Stack (most recent call first): CMakeLists.txt:4 (find_package) You don't have kdelibs-devel installed as it's BR. F10 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1234342 (In reply to comment #3) > You don't have kdelibs-devel installed as it's BR. > > F10 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1234342 yes you are correct. something goes wrong when I tried to install kdelibs-devel and I assumed I have it installed. mirrors are not in sync. Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1231229 + rpmlint output for SRPM and for RPM. kvkbd.i586: W: dangling-symlink /usr/share/doc/HTML/en/kvkbd/common /usr/share/doc/HTML/en/common ==> Can be ignored. + source files match upstream url 342e8e7fcfc54d978615b1c2d019cbe5 94374-kvkbd-0.6.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI app. APPROVED. New Package CVS Request ======================= Package Name: kvkbd Short Description: Virtual keyboard for KDE Owners: jreznik Branches: F-9 F-10 InitialCC: And thanks for quick review! CVS Done If this package is built for all requested branches then can we have this review closed now? Yes, it's in stable repository & rawhide. |