Bug 490322

Summary: bash no longer complete filenames with spaces in them
Product: [Fedora] Fedora Reporter: Scott Tsai <scottt.tw>
Component: bash-completionAssignee: Roman Rakus <rrakus>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: rrakus, sheltren, tsmetana, twaugh, ville.skytta, yaneti
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.0-2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-07 19:05:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
workaround patch none

Description Scott Tsai 2009-03-15 09:39:43 UTC 
Description of problem:
bash in rawhide no longer offers completion for a directory named 'a b c' when I type "a\ TAB". It used to on Fedora 10.

Version-Release number of selected component (if applicable):
bash-4.0-3.fc11.x86_64

How reproducible:
Always

Steps to Reproduce:
1. mkdir 'a b c'
2. In an interactive shell type: ls a\ TAB

  
Actual results:
No completion offered.

Expected results:
bash offers the completion:
ls a\ b\ c/

Additional info:
Comment 1 Yanko Kaneti 2009-03-15 10:00:46 UTC 
Created attachment 335244 [details]
workaround patch

I am using this workaround patch for this particular issue. Not sure if it fits in the filedir logic there. Worksforme..
Comment 2 Yanko Kaneti 2009-03-15 10:06:20 UTC 
Ugh, sorry, I just notcied this is against bash. Plain bash filename with spaces completion works for me here. Current bash-completion in rawhide, messes up with it, and that previous patch is for it.
Comment 3 Scott Tsai 2009-03-15 10:35:56 UTC 
Yanko, I uninstalled bash-completion and the bug indeed went away. Thanks! I'll re-file this bug against bash-completion then.
Comment 4 Scott Tsai 2009-03-15 10:40:00 UTC 
Completion fails on filenames with spaces in them when:
bash-completion-20080705-3.20090211git47d0c5b.noarch
is installed. It works in plain bash.
Comment 5 Ville Skyttä 2009-03-15 20:03:47 UTC 
I can't reproduce with bash 3.2 and don't have a bash 4 setup available right now.  Bug forwarded upstream at http://alioth.debian.org/tracker/index.php?func=detail&aid=311544&group_id=100114&atid=413095
Comment 6 Scott Tsai 2009-04-07 17:26:45 UTC 
I updated bash-completion (bash-completion-1.0-1.fc11.noarch, bash-4.0-5.fc11.x86_64) and this bug is still present.

From Ville's upstream bug report, I understand we're waiting for a change effecting 'quote_readline' in bash, just wanted to see if you guys decided to integrate the workaround before that's fixed ;)
Comment 7 Ville Skyttä 2009-04-07 17:48:09 UTC 
The workaround would obviously be only applicable to bash 4.x.  Meanwhile, a different fix has been committed to upstream master branch.  It should have pretty much the same effect as the patch in comment 1, but could you test it anyway just to be sure and let me know if it fixes the issue?

http://git.debian.org/?p=bash-completion/bash-completion.git;a=commitdiff_plain;h=1421e55aac075e13491cd212b796bdd453214a2c
Comment 8 Scott Tsai 2009-04-07 18:09:27 UTC 
The patch works for my test case :)
Comment 9 Ville Skyttä 2009-04-07 19:05:58 UTC 
Thanks for testing.  The patch is included in 1.0-2.