Bug 490355

Summary: Review Request: emacs-jde - Emacs module for java develop
Product: [Fedora] Fedora Reporter: Dan Atmakin <beolnix>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: cassmodiah, cwickert, fedora-package-review, loganjerry, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-10-12 06:43:54 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 490352, 490354    
Bug Blocks: 201449    

Description Dan Atmakin 2009-03-15 13:16:39 EDT
Spec URL: http://dev.sgu.ru/b/SPECS/emacs-jde.spec
SRPM URL: http://dev.sgu.ru/b/SRPMS/emacs-jde-2.3.5.1-1.fc10.src.rpm
Description: JDEE, an add-on software package that turns Emacs into a comprehensive system for creating, editing, debugging, and documenting Java applications.

(!)Requires: 
emacs-cedet -- https://bugzilla.redhat.com/show_bug.cgi?id=490352#c0
emacs-elib -- https://bugzilla.redhat.com/show_bug.cgi?id=490354#c0
Comment 1 Jason Tibbitts 2009-03-15 14:33:31 EDT
You can set the ticket dependency fields to make sure that reviewers see the tickets in order.

Are these your first pacakges for Fedora?  I can't do a meaningful search for "Dan" in the account system.
Comment 2 Dan Atmakin 2009-03-15 14:47:49 EDT
(In reply to comment #1)
> You can set the ticket dependency fields to make sure that reviewers see the
> tickets in order.
> 
> Are these your first pacakges for Fedora?  I can't do a meaningful search for
> "Dan" in the account system.  

Thanks for hints.
Yes, it's my first packages for Fedora. I changed real name, hope it will be unique.
Comment 3 Jerry James 2009-06-01 14:51:55 EDT
The ChangeLog for the xemacs-packages-extra RPM has this entry:

* Fri Mar 03 2006 Ville Skyttä <ville.skytta at iki.fi> - 20051208-2
- Drop JDE; the full source for jde.jar doesn't seem to be available
  and even the included parts won't build with gcj eg. due to use of
  com.sun.* things.  Additionally it requires third party jars which are
  not currently available in Fedora Core or Extras.  So let's not inflict
  a crippled version of JDE on anyone; JDE users can install the upstream
  jde package using XEmacs package tools. (#180941)

How much of that is true for this package?
Comment 4 Dan Atmakin 2009-06-01 17:04:53 EDT
This is a package for emacs and in emacs pattern, this package is absolutely all-sufficient and does not requires any special jars for correct work. Only preinstalled jre (sun or another, it does not matter). I don't know how JDE work in xemacs.

sorry but this srpm is rather ugly. I will recreate it according with /Packaging/Emacs#GNU_Emacs guidelines. I can't do it immediately, but i'll try to fix all problems in the near future.
Comment 5 Jerry James 2009-06-24 17:09:08 EDT
With respect to comment #3, please note that Ville's comments are absolutely correct for this package as well.  In the source distribution's java/lib directory are some jars with no corresponding sources: bsh.jar (which appears to include some classes from objectweb-asm), checkstyle.jar (which includes some classes from antlr, several jakarta-commons packages, and something from puppycrawl.com), and junit.jar.  Also try "grep -RF com.sun java/src".  In addition, the complaint that some source files are missing is absolutely valid.  Note that java/src/jde.jar contains "jde/debugger/gui/ThreadDisplay.class".  Where's the source file for that?
Comment 6 Simon 2009-10-12 03:13:47 EDT
Links return 404