Bug 490475

Summary:	API - auth.login() - provide better error messages on exception
Product:	[Community] Spacewalk	Reporter:	Brad Buckingham <bbuckingham>
Component:	API	Assignee:	Brad Buckingham <bbuckingham>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jesus M. Rodriguez <jesusr>
Severity:	medium	Docs Contact:
Priority:	low
Version:	0.5	CC:	bperkins
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-17 07:11:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	456553

Description Brad Buckingham 2009-03-16 16:25:20 UTC

Description of problem:

Update XMLRRPC API auth.login() to return error messages that are consistent with the errors displayed to them if logging in through the UI.


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. invoke auth.login() with a user that is 
   a. deactivate or 
   b. with an invalid login or password
  
Actual results:
1. a. account.disabled
1. b. error.invalid_login

Expected results:
1. a. "Your account has been deactivated."
1. b. "Either the password or username is incorrect."

Additional info:

Comment 1 Brad Buckingham 2009-03-16 16:35:06 UTC

git commit: 775a37377feadedd46221a615586fd9145f148e1

Updated the API to use the localized error text that a user gets if they attempted a failed login scenario from the UI.  

The new output to a failed attempt to login via API looks like:


xmlrpclib.Fault: <Fault 2950: 'redstone.xmlrpc.XmlRpcFault: Either the password or username is incorrect.'>

xmlrpclib.Fault: <Fault 2950: 'redstone.xmlrpc.XmlRpcFault: Your account has been deactivated.'>

Comment 2 Brad Buckingham 2009-03-23 20:28:24 UTC

mass move to ON_QA

Comment 3 Brandon Perkins 2009-03-24 01:20:55 UTC

Removing bug 490475 blocks bug 488488.

Comment 4 Jesus M. Rodriguez 2009-04-14 14:13:34 UTC

Spacewalk 0.5 released.

Comment 5 Miroslav Suchý 2009-09-17 07:11:16 UTC

Spacewalk 0.5 has been released for long time ago.