Bug 490491

Summary:	Review Request: sysbench - System performance benchmark
Product:	[Fedora] Fedora	Reporter:	Xavier Bachelot <xavier>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, pahan, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.4.10-3.fc9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-18 19:12:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xavier Bachelot 2009-03-16 17:31:38 UTC

Spec URL: http://www.bachelot.org/fedora/SPECS/sysbench.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/sysbench-0.4.10-2.fc10.src.rpm
Description:
SysBench is a modular, cross-platform and multi-threaded benchmark
tool for evaluating OS parameters that are important for a system
running a database under intensive load.

The idea of this benchmark suite is to quickly get an impression about
system performance without setting up complex database benchmarks or
even without installing a database at all. Current features allow to
test the following system parameters:
- file I/O performance
- scheduler performance
- memory allocation and transfer speed
- POSIX threads implementation performance
- database server performance (OLTP benchmark)

Primarily written for MySQL server benchmarking, SysBench will be
further extended to support multiple database backends, distributed
benchmarks and third-party plug-in modules.

Comment 1 Parag AN(पराग) 2009-03-17 09:52:37 UTC

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1245737
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0820760bb16783ae51994aed794f952d  sysbench-0.4.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package installed successfully.
+ Not a GUI app.

suggestions:
1) license looks to be GPLv2+

Comment 2 Xavier Bachelot 2009-03-17 11:38:08 UTC

Thanks for the review, I'll fix the license before building.

New Package CVS Request
=======================
Package Name: sysbench
Short Description: System performance benchmark
Owners: xavierb
Branches: F-9 F-10 EL-4 EL-5
InitialCC:

Comment 3 Kevin Fenzi 2009-03-18 03:34:50 UTC

cvs done.

Comment 4 Xavier Bachelot 2009-03-18 09:06:51 UTC

Imported and built for F-9, F-10, EL-4 and EL-5.

Comment 5 Fedora Update System 2009-03-18 09:46:36 UTC

sysbench-0.4.10-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/sysbench-0.4.10-3.fc9

Comment 6 Fedora Update System 2009-03-18 09:46:42 UTC

sysbench-0.4.10-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/sysbench-0.4.10-3.fc10

Comment 7 Fedora Update System 2009-03-18 19:12:39 UTC

sysbench-0.4.10-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-03-18 19:13:17 UTC

sysbench-0.4.10-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.