Red Hat Bugzilla – Bug 490491
Review Request: sysbench - System performance benchmark
Last modified: 2009-03-29 04:51:06 EDT
Spec URL: http://www.bachelot.org/fedora/SPECS/sysbench.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/sysbench-0.4.10-2.fc10.src.rpm Description: SysBench is a modular, cross-platform and multi-threaded benchmark tool for evaluating OS parameters that are important for a system running a database under intensive load. The idea of this benchmark suite is to quickly get an impression about system performance without setting up complex database benchmarks or even without installing a database at all. Current features allow to test the following system parameters: - file I/O performance - scheduler performance - memory allocation and transfer speed - POSIX threads implementation performance - database server performance (OLTP benchmark) Primarily written for MySQL server benchmarking, SysBench will be further extended to support multiple database backends, distributed benchmarks and third-party plug-in modules.
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1245737 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0820760bb16783ae51994aed794f952d sysbench-0.4.10.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package installed successfully. + Not a GUI app. suggestions: 1) license looks to be GPLv2+
Thanks for the review, I'll fix the license before building. New Package CVS Request ======================= Package Name: sysbench Short Description: System performance benchmark Owners: xavierb Branches: F-9 F-10 EL-4 EL-5 InitialCC:
cvs done.
Imported and built for F-9, F-10, EL-4 and EL-5.
sysbench-0.4.10-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/sysbench-0.4.10-3.fc9
sysbench-0.4.10-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sysbench-0.4.10-3.fc10
sysbench-0.4.10-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
sysbench-0.4.10-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.