Bug 491579
| Summary: | Review Request: jjack - JACK audio driver for the Java Sound API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-27 18:44:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 492203 | ||
|
Description
Orcan Ogetbil
2009-03-23 06:14:07 UTC
Fedora review jjack-0.3-1.fc10.src.rpm 2009-04-26 rpmlint: 4 packages and 1 specfiles checked; 0 errors, 0 warnings. * Package is named according to guidelines * Specfile is named after the package * The package follows the guidelines for a java package using JNI * License is Fedora approved: LGPLv2+ * The License tags in the sources only says LGPL without version. According to the https://fedoraproject.org/wiki/Licensing page LGPL without version is equivalent to LGPLv2+. ("Note that this is LGPLv2+, not LGPL+, because version 2 was the first version of LGPL.") The version number in the LICENSE file itself is not relevant for (L)GPL. * The LICENSE file is packaged as %doc * Specfile is written in legible English * Sources matches upstream to the extent possible (differences are documented): $ diff -ur SRPM/jjack-0.3 jjack-0.3 Only in jjack-0.3/doc/www: mp3 Only in SRPM/jjack-0.3/doc/www: ogg * Package compiles in mock (Fedora 10) * BuildRequires are sane * Package owns directories it creates * No duplicate files * Permissions are sane and %files has %defattr * %clean clears buildroot * Macros are used consistently * Documentation is in javadoc subpackage * %doc is not runtime essential * Package does not own other's directories * %install clears buildroot * Installed files are valid UTF-8 One small suggestion: The wrapper script passes its arguments on as $1 $2 $3 $4 $5 It is probably better to instead do "$@" (including the quotes). This will work better in cases where there are empty arguments ("") or quoted arguments containing spaces, subtleties that now get lost. Package approved. Thanks a lot, I will update the script. New Package CVS Request ======================= Package Name: jjack Short Description: JACK audio driver for the Java Sound API Owners: oget Branches: F-9 F-10 F-11 InitialCC: cvs done. jjack-0.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jjack-0.3-2.fc11 jjack-0.3-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/jjack-0.3-2.fc10 jjack-0.3-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/jjack-0.3-2.fc9 Package imported and built. Closing. jjack-0.3-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. jjack-0.3-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. jjack-0.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |