Bug 491884
| Summary: | Review Request: atasm - 6502 cross-assembler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Horák <dan> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-08 08:31:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dan Horák
2009-03-24 14:25:18 UTC
Builds fine and rpmlint is silent. There's really not much to this package; the only thing I can note is that the documentation makes up about 80% of the package, but it's still very small and splitting out the docs would be dumb. * source files match upstream. sha256sum: 9822e96baa39a16e8c46c0d4892bd76157f7de1fffd6c8d6ced1bda809450171 atasm106.zip * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: atasm = 1.06-1.fc11 atasm(x86-64) = 1.06-1.fc11 = libz.so.1()(64bit) * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Hmm, I just noticed that you manually gzip the manpage; I would recommend against that as rpm will do it for you one day we may want to change the compression method. Thanks for the review, I will update the spec before importing. New Package CVS Request ======================= Package Name: atasm Short Description: 6502 cross-assembler Owners: sharkcz Branches: F-9 F-10 EL-5 cvs done. imported and built |