Red Hat Bugzilla – Bug 491884
Review Request: atasm - 6502 cross-assembler
Last modified: 2009-04-08 04:31:21 EDT
Spec URL: http://fedora.danny.cz/atasm.spec
SRPM URL: http://fedora.danny.cz/atasm-1.06-1.fc11.src.rpm
ATasm is a 6502 command-line cross-assembler that is compatible with the
original Mac/65 macroassembler released by OSS software. Code
development can now be performed using "modern" editors and compiles
with lightning speed.
Builds fine and rpmlint is silent. There's really not much to this package; the only thing I can note is that the documentation makes up about 80% of the package, but it's still very small and splitting out the docs would be dumb.
* source files match upstream. sha256sum:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
atasm = 1.06-1.fc11
atasm(x86-64) = 1.06-1.fc11
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Hmm, I just noticed that you manually gzip the manpage; I would recommend against that as rpm will do it for you one day we may want to change the compression method.
Thanks for the review, I will update the spec before importing.
New Package CVS Request
Package Name: atasm
Short Description: 6502 cross-assembler
Branches: F-9 F-10 EL-5
imported and built