Bug 492201
| Summary: | Review Request: tootaudioservers - Toot2 Audio Server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Rakesh Pandit <rpandit> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | rpandit:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 3-0.1.beta2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-27 17:59:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 492197 | ||
| Bug Blocks: | 492203 | ||
|
Description
Orcan Ogetbil
2009-03-25 20:42:02 UTC
Spec URL: http://oget.fedorapeople.org/review/tootaudioservers.spec SRPM URL: http://oget.fedorapeople.org/review/tootaudioservers-2.0-2.64svn.fc10.src.rpm Changelog: 2.0-2.64svn - Don't build AOT bits (this package requires java > 1.5) New upstream version in conjunction with toot2 Spec URL: http://oget.fedorapeople.org/review/tootaudioservers.spec SRPM URL: http://oget.fedorapeople.org/review/tootaudioservers-3-0.1.beta2.fc10.src.rpm Changelog: 3-0.1.beta2 - Update to 3beta2 Builds in koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1398081 will review shortly Builds fine. Package looks fine to me except .. add it a script or few commands in spec itself via which you extracted tarball from cvs and removed unnecessary files. Thanks, package naming -- done api-subpackage -- done debuginfo -- done package naming - fine spec file language -- sane spec file - legible md5sum matches -- done Compiles -- successfully Build on koji rpmlint output - mentioned buildrequires - fine %files - fine -doc package - fine (In reply to comment #5) > Builds fine. > > Package looks fine to me except .. add it a script or few commands in spec > itself via which you extracted tarball from cvs and removed unnecessary files. > Thanks, Actually that is what the Source9: %{name}-snapshot.sh is for. I find it easier to use this script to fetch the sources. I remove the unnecessary files (the bundled prebuilt .so files) in %prep so that the snapshot tarball matches what upstream gives. Also I'd like to keep the fetch script as plain as possible and do my business in the spec file. APPROVED. Thanks for the review! New Package CVS Request ======================= Package Name: tootaudioservers Short Description: Toot2 Audio Server Owners: oget Branches: F-10 F-11 InitialCC: CVS done. tootaudioservers-3-0.1.beta2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tootaudioservers-3-0.1.beta2.fc11 tootaudioservers-3-0.1.beta2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tootaudioservers-3-0.1.beta2.fc10 Package in rawhide now. Thanks. tootaudioservers-3-0.1.beta2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. tootaudioservers-3-0.1.beta2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |