Spec URL: http://oget.fedorapeople.org/review/tootaudioservers.spec SRPM URL: http://oget.fedorapeople.org/review/tootaudioservers-2.0-1.64svn.fc10.src.rpm Description: Tootaudioservers provides access to audio hardware using various implementations of the toot2 project AudioServer and AudioServerConfiguration interfaces. Various JavaSound implementations are supplied as services. rpmlint: tootaudioservers.x86_64: W: no-documentation but upstream provides no doc files.
Spec URL: http://oget.fedorapeople.org/review/tootaudioservers.spec SRPM URL: http://oget.fedorapeople.org/review/tootaudioservers-2.0-2.64svn.fc10.src.rpm Changelog: 2.0-2.64svn - Don't build AOT bits (this package requires java > 1.5)
New upstream version in conjunction with toot2 Spec URL: http://oget.fedorapeople.org/review/tootaudioservers.spec SRPM URL: http://oget.fedorapeople.org/review/tootaudioservers-3-0.1.beta2.fc10.src.rpm Changelog: 3-0.1.beta2 - Update to 3beta2
Builds in koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1398081
will review shortly
Builds fine. Package looks fine to me except .. add it a script or few commands in spec itself via which you extracted tarball from cvs and removed unnecessary files. Thanks, package naming -- done api-subpackage -- done debuginfo -- done package naming - fine spec file language -- sane spec file - legible md5sum matches -- done Compiles -- successfully Build on koji rpmlint output - mentioned buildrequires - fine %files - fine -doc package - fine
(In reply to comment #5) > Builds fine. > > Package looks fine to me except .. add it a script or few commands in spec > itself via which you extracted tarball from cvs and removed unnecessary files. > Thanks, Actually that is what the Source9: %{name}-snapshot.sh is for. I find it easier to use this script to fetch the sources. I remove the unnecessary files (the bundled prebuilt .so files) in %prep so that the snapshot tarball matches what upstream gives. Also I'd like to keep the fetch script as plain as possible and do my business in the spec file.
APPROVED.
Thanks for the review! New Package CVS Request ======================= Package Name: tootaudioservers Short Description: Toot2 Audio Server Owners: oget Branches: F-10 F-11 InitialCC:
CVS done.
tootaudioservers-3-0.1.beta2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tootaudioservers-3-0.1.beta2.fc11
tootaudioservers-3-0.1.beta2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tootaudioservers-3-0.1.beta2.fc10
Package in rawhide now. Thanks.
tootaudioservers-3-0.1.beta2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
tootaudioservers-3-0.1.beta2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.