Bug 492250
| Summary: | Review Request: perl-Git-CPAN-Patch - Patch CPAN modules using Git | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Git-CPAN-Patch/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-28 07:26:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2009-03-26 04:56:47 UTC
Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1259176 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3ca356d3896cf37a7133301fc9678ff2 Git-CPAN-Patch-0.1.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Files=1, Tests=1, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.05 cusr 0.01 csys = 0.10 CPU) + Package perl-Git-CPAN-Patch-0.1.4-2.fc11.noarch -> Provides: perl(Git::CPAN::Patch) = 0.1.4 Requires: perl(strict) perl(warnings) Can subpackage be named as git-cpan instead of git-cpan-patch? (In reply to comment #1) > > Can subpackage be named as git-cpan instead of git-cpan-patch? Yes, it definitely can... I thought about it, and figured I should be consistent with the module naming in case someone else came up with a Git::CPAN; but I don't have any problems with renaming it to git-cpan. (In reply to comment #2) > (In reply to comment #1) > > > > Can subpackage be named as git-cpan instead of git-cpan-patch? > > Yes, it definitely can... I thought about it, and figured I should be > consistent with the module naming in case someone else came up with a > Git::CPAN; but I don't have any problems with renaming it to git-cpan. Thanks. Good then if you change it to git-cpan. APPROVED. New Package CVS Request ======================= Package Name: perl-Git-CPAN-Patch Short Description: Patch CPAN modules using Git Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig cvs done. Thanks for the review! :-) |