Red Hat Bugzilla – Bug 492250
Review Request: perl-Git-CPAN-Patch - Patch CPAN modules using Git
Last modified: 2016-08-14 12:23:18 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Git-CPAN-Patch.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Git-CPAN-Patch-0.1.4-2.fc10.src.rpm
Git::CPAN::Patch provides a suite of git commands aimed at making trivially
easy the process of grabbing any distribution off CPAN, stuffing it in a
local git repository and, once gleeful hacking has been perpetrated,
sending back patches to its maintainer.
This package provides the backend Perl modules required. For the git
commands, etc, please install the git-cpan-patch package.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1259176
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1259176
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=1, Tests=1, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.05 cusr 0.01 csys = 0.10 CPU)
+ Package perl-Git-CPAN-Patch-0.1.4-2.fc11.noarch ->
Provides: perl(Git::CPAN::Patch) = 0.1.4
Requires: perl(strict) perl(warnings)
Can subpackage be named as git-cpan instead of git-cpan-patch?
(In reply to comment #1)
> Can subpackage be named as git-cpan instead of git-cpan-patch?
Yes, it definitely can... I thought about it, and figured I should be consistent with the module naming in case someone else came up with a Git::CPAN; but I don't have any problems with renaming it to git-cpan.
(In reply to comment #2)
> (In reply to comment #1)
> > Can subpackage be named as git-cpan instead of git-cpan-patch?
> Yes, it definitely can... I thought about it, and figured I should be
> consistent with the module naming in case someone else came up with a
> Git::CPAN; but I don't have any problems with renaming it to git-cpan.
Thanks. Good then if you change it to git-cpan.
New Package CVS Request
Package Name: perl-Git-CPAN-Patch
Short Description: Patch CPAN modules using Git
Branches: F-9 F-10 devel
Thanks for the review! :-)