Bug 492600 (oxygen-icon-theme)

Summary:	Review Request: oxygen-icon-theme - Oxygen Icon Theme
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	Package Review	Assignee:	Jaroslav Reznik <jreznik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, jreznik, notting
Target Milestone:	---	Flags:	jreznik: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-07-26 20:25:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rex Dieter 2009-03-27 16:43:59 UTC

Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/oxygen-icon-theme/oxygen-icon-theme.spec
SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/oxygen-icon-theme/oxygen-icon-theme-4.2.1-10.fc10.src.rpm
Description: Oxygen Icon Theme

This was once packaged as part of kdebase-runtime, but upstream kde-artwork team has pending plans to release oxygen separately.  This submission currently still uses the kdebase-runtime tarball, and serves as an intermediate step so that we're ready when proper oxygen releases happen.

Comment 1 Jaroslav Reznik 2009-03-30 15:12:37 UTC

package name: OK
SPEC name matches package name: OK
rpmlint: NOT OK
  - oxygen-icon-theme.noarch: W: no-documentation
  - there are docs in pics/oxygen/, at least COPYING has to be distributed with this package
buildroot: OK
license: NOT OK
  - oxygen theme is licensed under LGPLv3+ not GPLv2
source md5 matches upstream: OK
buildrequires: OK
  - remove bogus BRs after oxygen standalone release
package owns created dirs: NOT OK?
  - main package: OK
  - scalable: ? as rpmls doesn't list created directories
permissions: OK
clean section: OK
no dupes: OK
package builds on: F10

Comment 2 Rex Dieter 2009-03-30 15:29:24 UTC

* Mon Mar 30 2009 Rex Dieter <rdieter> - 4.2.1-11
- License: LGPLv3+
- %%doc: AUTHORS CONTRIBUTING COPYING TODO*

Spec URL:
http://rdieter.fedorapeople.org/pkg-reviews/oxygen-icon-theme/oxygen-icon-theme.spec

(didn't re-up the biggish srpm)

Comment 3 Jaroslav Reznik 2009-03-30 15:47:38 UTC

Ok, thanks.
I'm not sure about owner of all scalable directories.

Comment 4 Rex Dieter 2009-03-30 18:08:23 UTC

The parent pkg owns all dirs.

Fwiw, it would seem that for future releases, it would appear that upstream will drop these from distribution anyway.

Comment 5 Jaroslav Reznik 2009-03-30 20:19:23 UTC

Well, APPROVED.

Comment 6 Rex Dieter 2009-03-30 20:47:26 UTC

New Package CVS Request
=======================
Package Name: oxygen-icon-theme
Short Description: Oxygen Icon Theme
Owners: rdieter,than,jreznik,ltinkl,kkofler
Branches: F-9 F-10

Comment 7 Kevin Fenzi 2009-03-30 21:37:14 UTC

cvs done.