Bug 493232
Summary: | Review Request: redir - Redirect TCP connections | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Itamar Reis Peixoto <itamar> |
Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora, pahan |
Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 2.2.1-3.fc10 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-04-07 15:47:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Itamar Reis Peixoto
2009-04-01 01:54:43 UTC
Not that you have to use any of them, but the Debian version of this package comes with quite a lot of fixes/patches. They have this packaged for quite a while and they have probably figured out what bugs it has. Did you have a look? Maybe you'll find something really useful. for me there are no problems,I can apply all debian patches, I will include a new spec here soon, feel free to review it if you like. new version with debian patches included. http://ispbrasil.com.br/redir/redir.spec http://ispbrasil.com.br/redir/redir-2.2.1-2.fc11.src.rpm koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1271438 Hi, I went through the package. There are a few issues: * Guidelines say: All patches should have an upstream bug link or comment. Since this project is pretty old I don't think it matters to send these patches upstream. But at least, you should briefly explain in the SPEC file what each of them does. Ref: http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment * COPYING file _must_ go to %doc ! CHANGES file can go to %doc ? There is a mod and a wrapper shell script in the contrib/ directory. Are they worth packaging? ! %attr(755,root,root) is redundant, can be removed * gcc warnings: There are a couple of these warnings (gcc44): redir.c:496: warning: passing argument 3 of 'getsockname' from incompatible pointer type /usr/include/sys/socket.h:119: note: expected 'socklen_t * __restrict__' but argument is of type 'size_t *' I'm sure these can be fixed easily. * optflags are not passed during the linking phase. At the least "-g -Wall" should be passed. To be safe, you can add LDFLAGS="$RPM_OPT_FLAGS" to the end of the make line. (In reply to comment #4) > ? There is a mod and a wrapper shell script in the contrib/ directory. Are they > worth packaging? most people use redir standalone, I belive this script is not packaged it other distros too, I have no plans to package it http://ispbrasil.com.br/redir/redir.spec http://ispbrasil.com.br/redir/redir-2.2.1-3.fc11.src.rpm koji scratch build dist-f11 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1277430 Thanks, everything seems fine, except now we have the rpmlint: redir.x86_64: W: file-not-utf8 /usr/share/doc/redir-2.2.1/CHANGES This can be fixed with iconv. Please do that before you commit. ---------------------------------------- This package (redir) is APPROVED by oget ---------------------------------------- New Package CVS Request ======================= Package Name: redir Short Description: Redirect TCP connections Owners: itamarjp Branches: F-11 F-10 F-9 InitialCC: Uhm, one last little thing. Please update 15_deb_cosmetics.dpatch to point to the correct %doc location. Thanks. (In reply to comment #8) ok, I will do this before importing into cvs cvs done. redir-2.2.1-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/redir-2.2.1-3.fc9 redir-2.2.1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/redir-2.2.1-3.fc10 redir-2.2.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. redir-2.2.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: redir New Branches: EL-4 EL-5 Owners: itamarjp cvs done. |