Red Hat Bugzilla – Bug 493232
Review Request: redir - Redirect TCP connections
Last modified: 2009-09-24 00:41:17 EDT
Spec URL: http://ispbrasil.com.br/redir/redir.spec
SRPM URL: http://ispbrasil.com.br/redir/redir-2.2.1-1.fc11.src.rpm
a port redirector, used to forward incoming connections to somewhere else.
koji scratch build dist-f11 ---->
Not that you have to use any of them, but the Debian version of this package comes with quite a lot of fixes/patches. They have this packaged for quite a while and they have probably figured out what bugs it has. Did you have a look? Maybe you'll find something really useful.
for me there are no problems,I can apply all debian patches, I will include a new spec here soon, feel free to review it if you like.
new version with debian patches included.
koji scratch build ->
Hi, I went through the package. There are a few issues:
* Guidelines say:
All patches should have an upstream bug link or comment. Since this project is pretty old I don't think it matters to send these patches upstream. But at least, you should briefly explain in the SPEC file what each of them does.
* COPYING file _must_ go to %doc
! CHANGES file can go to %doc
? There is a mod and a wrapper shell script in the contrib/ directory. Are they worth packaging?
! %attr(755,root,root) is redundant, can be removed
* gcc warnings: There are a couple of these warnings (gcc44):
redir.c:496: warning: passing argument 3 of 'getsockname' from incompatible pointer type
/usr/include/sys/socket.h:119: note: expected 'socklen_t * __restrict__' but argument is of type 'size_t *'
I'm sure these can be fixed easily.
* optflags are not passed during the linking phase. At the least "-g -Wall" should be passed. To be safe, you can add LDFLAGS="$RPM_OPT_FLAGS" to the end of the make line.
(In reply to comment #4)
> ? There is a mod and a wrapper shell script in the contrib/ directory. Are they
> worth packaging?
most people use redir standalone, I belive this script is not packaged it other distros too, I have no plans to package it
koji scratch build dist-f11 ->
Thanks, everything seems fine, except now we have the rpmlint:
redir.x86_64: W: file-not-utf8 /usr/share/doc/redir-2.2.1/CHANGES
This can be fixed with iconv. Please do that before you commit.
This package (redir) is APPROVED by oget
New Package CVS Request
Package Name: redir
Short Description: Redirect TCP connections
Branches: F-11 F-10 F-9
Uhm, one last little thing. Please update 15_deb_cosmetics.dpatch to point to the correct %doc location. Thanks.
(In reply to comment #8)
ok, I will do this before importing into cvs
redir-2.2.1-3.fc9 has been submitted as an update for Fedora 9.
redir-2.2.1-3.fc10 has been submitted as an update for Fedora 10.
redir-2.2.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
redir-2.2.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request
Package Name: redir
New Branches: EL-4 EL-5