Bug 493509

Summary:	[PATCH] ibus-hangul missing right Ctrl for Hanja button
Product:	[Fedora] Fedora	Reporter:	Warren Togami <wtogami>
Component:	ibus-hangul	Assignee:	Peng Huang <phuang>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	i18n-bugs, phuang
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-04-13 18:58:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	446452, 481098

Description Warren Togami 2009-04-02 02:45:38 UTC

Windows XP and Windows Vista with US keyboard layout.

* right-Alt acts as Hangul/English button.  It does not dismiss the language bar.  It only switches between 한 and En.
* right-CTRL acts as Hanja button.

We need this by default because it is very common for Koreans with US keyboards to expect this interface.

Comment 1 Warren Togami 2009-04-06 20:48:54 UTC

diff -urN ibus-hangul-1.1.0.20090328.orig/src/engine.c ibus-hangul-1.1.0.20090328/src/engine.c
--- ibus-hangul-1.1.0.20090328.orig/src/engine.c	2009-03-26 01:50:18.000000000 -0400
+++ ibus-hangul-1.1.0.20090328/src/engine.c	2009-04-06 16:20:44.935321507 -0400
@@ -450,7 +450,7 @@
     if (keyval == IBUS_Shift_L || keyval == IBUS_Shift_R)
         return FALSE;
 
-    if (keyval == IBUS_F9 || keyval == IBUS_Hangul_Hanja) {
+    if (keyval == IBUS_F9 || keyval == IBUS_Hangul_Hanja || keyval == IBUS_Control_R) {
 	ibus_hangul_engine_toggle_lookup_table (hangul);
 	return TRUE;
     }

This makes it work for the non-Korean keyboard Hanja conversion button.  Filing the right Alt Han/En button as a separate bug since it requires more work.