Bug 493841

Summary: S-c-tools cleanup: inputs checking
Product: [Fedora] Fedora Reporter: Roman Rakus <rrakus>
Component: system-config-httpdAssignee: Phil Knirsch <pknirsch>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: jreznik, pknirsch, rnovacek, rvokal, tsmetana
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-10-02 12:30:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 493599    
Attachments:
Description Flags
Proposed patch that adds checking for valid ip addresses and ports none

Description Roman Rakus 2009-04-03 10:00:15 UTC 
Description of problem:
Every input should be tested and/or filtered.

How reproducible:
IP & ports

Steps to Reproduce:
Do something without sense. For example fill IP address field with zywe

Actual results:
Tool will not notify user, that he write it wrong.

Expected results:
In some cases you can filter input (appropriate settings on widget). Notify user about his mistake and don't let tool to traceback.

Additional info:
You can set appropriate settings. You can use signal changed and/or focus-out for text fields.
Comment 1 Radek Novacek 2009-07-27 12:03:31 UTC 
Created attachment 355268 [details]
Proposed patch that adds checking for valid ip addresses and ports

This patch adds checking for valid ip address and ports and also fixes calling:
raise 'TestError'
This statement does not work so I replace it with raising new class TestError which is derived from the class Exception.
Comment 2 Phil Knirsch 2009-10-02 12:30:48 UTC 
Patch looks good, applied to HG repo and will be in next build.

Thanks & regards, Phil