Bug 493841 - S-c-tools cleanup: inputs checking
Summary: S-c-tools cleanup: inputs checking
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-httpd
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Phil Knirsch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 493599
TreeView+ depends on / blocked
 
Reported: 2009-04-03 10:00 UTC by Roman Rakus
Modified: 2015-03-05 01:20 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-02 12:30:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Proposed patch that adds checking for valid ip addresses and ports (14.04 KB, patch)
2009-07-27 12:03 UTC, Radek Novacek
no flags Details | Diff

Description Roman Rakus 2009-04-03 10:00:15 UTC
Description of problem:
Every input should be tested and/or filtered.

How reproducible:
IP & ports

Steps to Reproduce:
Do something without sense. For example fill IP address field with zywe

Actual results:
Tool will not notify user, that he write it wrong.

Expected results:
In some cases you can filter input (appropriate settings on widget). Notify user about his mistake and don't let tool to traceback.

Additional info:
You can set appropriate settings. You can use signal changed and/or focus-out for text fields.

Comment 1 Radek Novacek 2009-07-27 12:03:31 UTC
Created attachment 355268 [details]
Proposed patch that adds checking for valid ip addresses and ports

This patch adds checking for valid ip address and ports and also fixes calling:
raise 'TestError'
This statement does not work so I replace it with raising new class TestError which is derived from the class Exception.

Comment 2 Phil Knirsch 2009-10-02 12:30:48 UTC
Patch looks good, applied to HG repo and will be in next build.

Thanks & regards, Phil


Note You need to log in before you can comment on or make changes to this bug.