Red Hat Bugzilla – Bug 493841
S-c-tools cleanup: inputs checking
Last modified: 2015-03-04 20:20:22 EST
Description of problem:
Every input should be tested and/or filtered.
IP & ports
Steps to Reproduce:
Do something without sense. For example fill IP address field with zywe
Tool will not notify user, that he write it wrong.
In some cases you can filter input (appropriate settings on widget). Notify user about his mistake and don't let tool to traceback.
You can set appropriate settings. You can use signal changed and/or focus-out for text fields.
Created attachment 355268 [details]
Proposed patch that adds checking for valid ip addresses and ports
This patch adds checking for valid ip address and ports and also fixes calling:
This statement does not work so I replace it with raising new class TestError which is derived from the class Exception.
Patch looks good, applied to HG repo and will be in next build.
Thanks & regards, Phil