Bug 495278

Summary:	Review Request: perl-DBIx-Class-DateTime-Epoch - Automatic inflation/deflation of epoch-based DateTime objects for DBIx::Class
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Iain Arnell <iarnell>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, iarnell, notting
Target Milestone:	---	Flags:	iarnell: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/DBIx-Class-DateTime-Epoch
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-04-12 20:24:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Weyl 2009-04-11 04:53:05 UTC

Spec URL: http://fedorapeople.org/~cweyl/review/perl-DBIx-Class-DateTime-Epoch.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DBIx-Class-DateTime-Epoch-0.03-1.fc10.src.rpm

Description:
This module automatically inflates/deflates DateTime objects
corresponding to applicable columns. Columns may also be defined to
specify their nature, such as columns representing a creation time
(set at time of insertion) or a modification time (set at time of
every update).

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1290500

*rt-0.06

Comment 1 Iain Arnell 2009-04-11 05:23:54 UTC

+ source files match upstream.  
  56c358f8f904fc0e939dd623a379c0884976a04d  DBIx-Class-DateTime-Epoch-0.03.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1290500

+ package installs properly.
+ rpmlint has no complaints:
  perl-DBIx-Class-DateTime-Epoch.noarch: I: checking
  perl-DBIx-Class-DateTime-Epoch.src: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
  perl(DBIx::Class::DateTime::Epoch) = 0.03
  perl-DBIx-Class-DateTime-Epoch = 0.03-1.fc11

=
  perl(:MODULE_COMPAT_5.10.0)  
  perl(DBIx::Class)  
  perl(DateTime)  
  perl(base)  
  perl(strict)  
  perl(warnings)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

+ %check is present and all tests pass.
  All tests successful.
  Files=3, Tests=3,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.34 cusr  0.03 csys =  0.40 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


APPROVED

Comment 2 Chris Weyl 2009-04-11 05:28:42 UTC

New Package CVS Request
=======================
Package Name: perl-DBIx-Class-DateTime-Epoch
Short Description: Automatic inflation/deflation of epoch-based DateTime objects for DBIx::Class
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-04-12 18:30:44 UTC

cvs done.

Comment 4 Chris Weyl 2009-04-12 20:24:24 UTC

Thanks for the review! :-)