Bug 495362
| Summary: | [PATCH] Improve error reporting a bit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> | ||||
| Component: | file-roller | Assignee: | Matthias Clasen <mclasen> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | mclasen | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-04-13 00:26:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 446451 | ||||||
| Attachments: |
|
||||||
Thats a fine patch to send upstream. But since it adds new translated strings, it will give a less than perfect experience - I'd say that it is only marginally better for a Chinese user to see some English sentence instead of "null". How about this instead ? --- fr-window.c.error-msg 2009-04-12 18:25:09.421337520 -0400 +++ fr-window.c 2009-04-12 18:26:45.327336763 -0400 @@ -2961,7 +2961,7 @@ 0, output, msg, - "%s", details); + details ? "%s" : NULL, details); fr_window_show_error_dialog (window, dialog, dialog_parent); return FALSE; (In reply to comment #1) > Thats a fine patch to send upstream. > But since it adds new translated strings, it will give a less than perfect > experience - I'd say that it is only marginally better for a Chinese user to > see some English sentence instead of "null". Well, it will propagate into .po files and probably get translated once. Sorry for not providing a Chinese translation ;) > How about this instead ? [...] Thought about that. Doesn't look well in that dialog, there's an empty space there. Filed upstream: http://bugzilla.gnome.org/show_bug.cgi?id=578800 |
Created attachment 339228 [details] Don't show a null error message Description of problem: Got a following error message: An error occurred while loading the archive. (null) Though it was rather clear from the command output that the archive is corrupted, a casual user would not appreciate seeing "(null)" in an error message. Please apply the patch that instructs the user to inspect the command output to find out the cause of the fail. Version-Release number of selected component (if applicable): file-roller-2.26.0-1.fc11.i586