Red Hat Bugzilla – Bug 495362
[PATCH] Improve error reporting a bit
Last modified: 2009-04-12 20:26:28 EDT
Created attachment 339228 [details]
Don't show a null error message
Description of problem:
Got a following error message:
An error occurred while loading the archive.
Though it was rather clear from the command output that the archive is corrupted, a casual user would not appreciate seeing "(null)" in an error message.
Please apply the patch that instructs the user to inspect the command output to find out the cause of the fail.
Version-Release number of selected component (if applicable):
Thats a fine patch to send upstream.
But since it adds new translated strings, it will give a less than perfect experience - I'd say that it is only marginally better for a Chinese user to see some English sentence instead of "null".
How about this instead ?
--- fr-window.c.error-msg 2009-04-12 18:25:09.421337520 -0400
+++ fr-window.c 2009-04-12 18:26:45.327336763 -0400
@@ -2961,7 +2961,7 @@
- "%s", details);
+ details ? "%s" : NULL, details);
fr_window_show_error_dialog (window, dialog, dialog_parent);
(In reply to comment #1)
> Thats a fine patch to send upstream.
> But since it adds new translated strings, it will give a less than perfect
> experience - I'd say that it is only marginally better for a Chinese user to
> see some English sentence instead of "null".
Well, it will propagate into .po files and probably get translated once. Sorry for not providing a Chinese translation ;)
> How about this instead ?
Thought about that. Doesn't look well in that dialog, there's an empty space there.