Bug 495875 (leonidas-kde-theme)
| Summary: | Review Request: leonidas-kde-theme - Leonidas KDE Theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Reznik <jreznik> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-22 20:30:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jaroslav Reznik
2009-04-15 11:05:10 UTC
I can take a look. tested it out... for a first try, it looks pretty darn good. rpmlint leonidas-kde-theme leonidas-kde-theme.noarch: W: dangling-relative-symlink /usr/share/wallpapers/leonidas_wide.png ../backgrounds/leonidas/lion/wide/1920x1200/leonidas-1-noon.png leonidas-kde-theme.noarch: W: dangling-relative-symlink /usr/share/wallpapers/leonidas_high.png ../backgrounds/leonidas/lion/normalish/1280x1024/leonidas-1-noon.png 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Tested against leonidas-backgrounds-common-10.93.1-1.fc11.noarch looks like the targets are jpg's not png's, but that's something that can be sorted out later. (nonblocking) SHOULD: 1. Address rpmlint warnings (above) 2. near Source URL, include a comment pointing to fedorahosted.org/leonidas-kde-theme upstream 3. License: leonidas-backgrounds-common is CC-BY-SA, but GPLV2 is also included here, is that the other/plymouth bits? (either way, documenting which parts are licensed which in a comment would help clarify for posterity). Otherwise, it's really a simple noarch pkg, and conformant. APPROVED. Backgrounds are JPG, we need PNG for KSplash, must be sorted out... 1. could I have a hint? 2. ok, I forgot it (was on TODO) 3. kdm Leonidas.xml is GPLv2 copyrighted (actually it's GPLv2+, I have to correct it) New Package CVS Request ======================= Package Name: leonidas-kde-theme Short Description: Leonidas KDE Theme Owners: jreznik rdieter kkofler than ltinkl Branches: F-11 cvs done. |