Bug 496206
| Summary: | xenkbd can crash when probe fails | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Markus Armbruster <armbru> | ||||||
| Component: | kernel-xen | Assignee: | Paolo Bonzini <pbonzini> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 4.9 | CC: | drjones, mjenner, pbonzini, qwan, syeghiay, xen-maint | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | 434800 | Environment: | |||||||
| Last Closed: | 2011-02-16 16:03:07 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 434800 | ||||||||
| Bug Blocks: | 458302 | ||||||||
| Attachments: |
|
||||||||
I redid the patch myself; I didn't use clear_page but, anyway, the only major difference between my patch and the one in comment #2 is that this: info->page = (void *)__get_free_page(GFP_KERNEL); + clear_page(info->page); if (!info->page) goto error_nomem; had a dereference-before-checking-for-NULL bug. Thanks! Created attachment 348628 [details]
patch sent to mailing list and acked
Committed in 89.7.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/ An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0263.html |
Created attachment 344815 [details] Proposed patch Backport of RHEL-5/linux-2.6-xen-pvfb-probe-suspend-fixes.patch and RHEL-5/linux-2.6-xen-pvfb-probe-suspend-fixes-fix.patch rolled together. Compile-tested only.