Bug 496206 - xenkbd can crash when probe fails
Summary: xenkbd can crash when probe fails
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel-xen
Version: 4.9
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Paolo Bonzini
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 434800
Blocks: 458302
TreeView+ depends on / blocked
 
Reported: 2009-04-17 09:17 UTC by Markus Armbruster
Modified: 2011-02-16 16:03 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 434800
Environment:
Last Closed: 2011-02-16 16:03:07 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Proposed patch (4.66 KB, patch)
2009-05-20 14:36 UTC, Markus Armbruster
no flags Details | Diff
patch sent to mailing list and acked (4.81 KB, patch)
2009-06-19 10:21 UTC, Paolo Bonzini
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0263 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 4.9 kernel security and bug fix update 2011-02-16 15:14:55 UTC

Comment 2 Markus Armbruster 2009-05-20 14:36:37 UTC
Created attachment 344815 [details]
Proposed patch

Backport of RHEL-5/linux-2.6-xen-pvfb-probe-suspend-fixes.patch and
RHEL-5/linux-2.6-xen-pvfb-probe-suspend-fixes-fix.patch rolled together.
Compile-tested only.

Comment 3 Paolo Bonzini 2009-06-16 16:19:49 UTC
I redid the patch myself; I didn't use clear_page but, anyway, the only major difference between my patch and the one in comment #2 is that this:

 	info->page = (void *)__get_free_page(GFP_KERNEL);
+	clear_page(info->page);
 	if (!info->page)
 		goto error_nomem;

had a dereference-before-checking-for-NULL bug.  Thanks!

Comment 4 Paolo Bonzini 2009-06-19 10:21:24 UTC
Created attachment 348628 [details]
patch sent to mailing list and acked

Comment 7 Vivek Goyal 2009-07-28 17:22:19 UTC
Committed in 89.7.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/

Comment 11 errata-xmlrpc 2011-02-16 16:03:07 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0263.html


Note You need to log in before you can comment on or make changes to this bug.