Bug 496757
| Summary: | Package Review: ibus-table-yong | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caius Chance <K9> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, K9, notting, panemade, petersen, phuang |
| Target Milestone: | --- | Keywords: | i18n, Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 488173 | Environment: | |
| Last Closed: | 2009-05-20 00:33:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Caius Chance
2009-04-21 00:08:42 UTC
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422-1.fc12.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong.spec Tarball URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422.tar.gz Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1313840 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3d8a91a171e16c6eac4c9c2f2b3ac218 ibus-table-yong-1.1.0.20090422.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions: 1) I think its ok to drop following line from %description Erbi is released under released under GPLv3. or modify to replace Erbi to Yong 2) can you remove following %verify(not md5 size mtime) ? SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422-2.fc12.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong.spec Tarball URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422.tar.gz koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1316239 APPROVED. can you request cvs? requested Heh, missing Request form! Package Name: ibus-table-yong Short Description: Yong table data for IBus Table Owners: cchance Branches: devel InitialCC: i18n-team cvs done. Package Change Request ====================== Package Name: ibus-table-yong New Branches: F-10, F-11 Owners: cchance cvs done. |