Bug 497647
| Summary: | "watch library for new files" causes plugin dialog to pop every time even after declining | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Charles R. Anderson <cra> | ||||
| Component: | rhythmbox | Assignee: | Bastien Nocera <bnocera> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | berarma, bnocera, notverysmart | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-06-28 12:12:39 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Charles R. Anderson
2009-04-25 15:24:21 UTC
I just got another one for: application/postscript My music library does contain extra files that I don't necessarily expect Rhythmbox to play or touch. I'd prefer if these were ignored perhaps after a single one-time prompt for each file. In other words, once I've declined a plugin search or if a plugin search fails for a particular file, it should remember that and not ask me again for that file. Even better would be to have two buttons: [Ignore this file] [Ignore all files of this type] (In reply to comment #1) > I just got another one for: > > application/postscript I've fixed the check for this filetype upstream, it's now ignored. The original problem is a bit harder. When asking for a plugin, we blacklist the requested type if a decoder wasn't installed. The blacklist is only kept per-run, so as to avoid files being ignored if a plugin for the type was installed in the meanwhile. We should be a bit more clever, and only show the popup when _playing_ the track, and show it in the unhandled/errors source when checking for metadata. I'll file a new bug upstream about that. Could you please try to make the files that caused those popups available somewhere? Then we could easily check that the UI problems are solved. Some additional file types that pop up: application/x-lha decoder application/x-java decoder (In reply to comment #4) > Some additional file types that pop up: > > application/x-lha decoder > application/x-java decoder Added those, still waiting on the other media files. Instead of adding every single application/* type that xdgmime will identify to the blacklist, we should use a whitelist for application/*. It looks like the only application/* types we accept are: application/x-id3 application/ogg possibly application/x-apetag possibly application/x-3gp I'm not exactly sure which files caused which popups... Created attachment 341736 [details]
rb-ignore-more-types.patch
Jonathan, does that look good to you?
Sure, that looks OK. I implemented a slightly different approach locally for testing, but that'll work just as well.
> I'm not exactly sure which files caused which popups...
That's one of the problems with the plugin install code at the moment. As far as I can tell, there's no way to pass that information through to the helper app.
Rhythmbox should ignore non audio files, everything without an "audio/*" MIME type. It should also give the option to disable plugin requests. It could import those files marking them as unplayable so it doesn't try to import them everytime it starts. Don't you think? This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping This message is a reminder that Fedora 11 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 11. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '11'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 11's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 11 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Fedora 11 changed to end-of-life (EOL) status on 2010-06-25. Fedora 11 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. |