Bug 497647 - "watch library for new files" causes plugin dialog to pop every time even after declining
Summary: "watch library for new files" causes plugin dialog to pop every time even aft...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: rhythmbox
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Bastien Nocera
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-25 15:24 UTC by Charles R. Anderson
Modified: 2010-06-28 12:12 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-06-28 12:12:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
rb-ignore-more-types.patch (2.19 KB, patch)
2009-04-29 11:13 UTC, Bastien Nocera
no flags Details | Diff

Description Charles R. Anderson 2009-04-25 15:24:21 UTC
Description of problem:

I keep getting popup dialogs asking for plugins after opening rhythmbox even before playing any songs.  After dismissing the dialog with the "Close" button, another one pops up.  This happens a few times in a row asking for different plugins.  Eventually it stops.

Version-Release number of selected component (if applicable):
rhythmbox-0.12.0.92-1.fc11.x86_64

How reproducible:
always

Steps to Reproduce:
1. open rhythmbox
2. Enable Edit->Preferences->Watch my library for new files
(you may have to close/reopen rhythmbox after setting this preference)
3. Either let it sit there, or play a file
4. If you don't play anything, the dialog pops without any filename/song name mentioned.
5. If you play a song, the dialog pops with that filename/song name, even though that song is actually playing, proving that it doesn't need any additional plugins to play it.
  
Actual results:

[Song Name]
An additional plugin is required to play
this content
The following plugin is required:

Module Music Format (MOD) decoder

Do you want to search for this now?

After clicking "Close" on the popup dialog, a new dialog appears, but this time for this plugin:

Sipro/ACELP.NET Voice decoder

then again for:

Amiga IFF / SVX8 / SV16 decoder

then:

SoundBlaster VOC decoder


Expected results:

The request for media plugins should only happen when the file is attempted to be played, not when it is discovered/added to the library, and certainly not every single time I open rhythmbox and decline to search for the required plugin.  No dialog popup should happen for the file that is currently playing correctly...

Additional info:

These are the gstreamer packages I have installed:

gstreamer-0.10.22-3.fc11.x86_64
gstreamer-ffmpeg-0.10.7-1.fc11.x86_64
gstreamer-plugins-base-0.10.22-2.fc11.x86_64
gstreamer-plugins-farsight-0.12.10-2.fc11.x86_64
gstreamer-plugins-flumpegdemux-0.10.15-6.fc11.x86_64
gstreamer-plugins-good-0.10.14-2.fc11.x86_64
gstreamer-plugins-schroedinger-1.0.6-1.fc11.x86_64
gstreamer-plugins-ugly-0.10.11-1.fc11.x86_64
gstreamer-python-0.10.14-2.fc11.x86_64
gstreamer-tools-0.10.22-3.fc11.x86_64

Comment 1 Charles R. Anderson 2009-04-25 15:33:55 UTC
I just got another one for:

application/postscript

My music library does contain extra files that I don't necessarily expect Rhythmbox to play or touch.  I'd prefer if these were ignored perhaps after a single one-time prompt for each file.  In other words, once I've declined a plugin search or if a plugin search fails for a particular file, it should remember that and not ask me again for that file.  Even better would be to have two buttons:

[Ignore this file]   [Ignore all files of this type]

Comment 2 Bastien Nocera 2009-04-25 15:57:52 UTC
(In reply to comment #1)
> I just got another one for:
> 
> application/postscript

I've fixed the check for this filetype upstream, it's now ignored.

The original problem is a bit harder. When asking for a plugin, we blacklist the requested type if a decoder wasn't installed. The blacklist is only kept per-run, so as to avoid files being ignored if a plugin for the type was installed in the meanwhile.

We should be a bit more clever, and only show the popup when _playing_ the track, and show it in the unhandled/errors source when checking for metadata.

Comment 3 Bastien Nocera 2009-04-25 15:59:00 UTC
I'll file a new bug upstream about that. Could you please try to make the files that caused those popups available somewhere? Then we could easily check that the UI problems are solved.

Comment 4 Charles R. Anderson 2009-04-25 21:43:32 UTC
Some additional file types that pop up:

application/x-lha decoder
application/x-java decoder

Comment 5 Bastien Nocera 2009-04-26 23:46:09 UTC
(In reply to comment #4)
> Some additional file types that pop up:
> 
> application/x-lha decoder
> application/x-java decoder  

Added those, still waiting on the other media files.

Comment 6 Jonathan Matthew 2009-04-27 00:20:58 UTC
Instead of adding every single application/* type that xdgmime will identify to the blacklist, we should use a whitelist for application/*.  It looks like the only application/* types we accept are:
  application/x-id3
  application/ogg
  possibly application/x-apetag
  possibly application/x-3gp

Comment 7 Charles R. Anderson 2009-04-27 14:10:07 UTC
I'm not exactly sure which files caused which popups...

Comment 8 Bastien Nocera 2009-04-29 11:13:20 UTC
Created attachment 341736 [details]
rb-ignore-more-types.patch

Jonathan, does that look good to you?

Comment 9 Jonathan Matthew 2009-04-29 11:39:28 UTC
Sure, that looks OK.  I implemented a slightly different approach locally for testing, but that'll work just as well.

> I'm not exactly sure which files caused which popups...  

That's one of the problems with the plugin install code at the moment.  As far as I can tell, there's no way to pass that information through to the helper app.

Comment 10 berarma 2009-05-24 14:11:12 UTC
Rhythmbox should ignore non audio files, everything without an "audio/*" MIME type. It should also give the option to disable plugin requests. It could import those files marking them as unplayable so it doesn't try to import them everytime it starts. Don't you think?

Comment 11 Bug Zapper 2009-06-09 14:33:34 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 12 Bug Zapper 2010-04-27 13:56:02 UTC
This message is a reminder that Fedora 11 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 11.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '11'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 11's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 11 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 13 Bug Zapper 2010-06-28 12:12:39 UTC
Fedora 11 changed to end-of-life (EOL) status on 2010-06-25. Fedora 11 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.