| Summary: | Review Request: perl-Crypt-CipherSaber - Perl module implementing CipherSaber encryption | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.00-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-02 16:26:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Xavier Bachelot
2009-04-25 21:06:50 UTC
+ source files match upstream. 2522e3de77fe005f13be3749e629b5234d449429 Crypt-CipherSaber-1.00.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1321099 + package installs properly. + rpmlint has no complaints: perl-Crypt-CipherSaber.noarch: I: checking perl-Crypt-CipherSaber.src: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(Crypt::CipherSaber) = 1.00 perl-Crypt-CipherSaber = 1.00-1.fc12 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Scalar::Util) perl(strict) perl(vars) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 + %check is present and all tests pass (with the caveat about Module::Signature) All tests successful. Files=10, Tests=32, 1 wallclock secs ( 0.07 usr 0.02 sys + 0.59 cusr 0.10 csys = 0.78 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED Thanks for the review Iain. New Package CVS Request ======================= Package Name: perl-Crypt-CipherSaber Short Description: Perl module implementing CipherSaber encryption Owners: xavierb Branches: F-9 F-10 F-11 EL-5 InitialCC: perl-sig cvs done. perl-Crypt-CipherSaber-1.00-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Crypt-CipherSaber-1.00-1.fc11 perl-Crypt-CipherSaber-1.00-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-Crypt-CipherSaber-1.00-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. perl-Crypt-CipherSaber-1.00-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |