Red Hat Bugzilla – Bug 497665
Review Request: perl-Crypt-CipherSaber - Perl module implementing CipherSaber encryption
Last modified: 2009-05-09 00:07:59 EDT
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Crypt-CipherSaber.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Crypt-CipherSaber-1.00-1.fc10.src.rpm
Description: The Crypt::CipherSaber module implements CipherSaber encryption, described at http://ciphersaber.gurus.com/. It is simple, fairly speedy, and relatively secure algorithm based on RC4.
+ source files match upstream.
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
+ package installs properly.
+ rpmlint has no complaints:
perl-Crypt-CipherSaber.noarch: I: checking
perl-Crypt-CipherSaber.src: I: checking
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(Crypt::CipherSaber) = 1.00
perl-Crypt-CipherSaber = 1.00-1.fc12
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
+ %check is present and all tests pass (with the caveat about
All tests successful.
Files=10, Tests=32, 1 wallclock secs ( 0.07 usr 0.02 sys + 0.59 cusr 0.10 csys = 0.78 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
Thanks for the review Iain.
New Package CVS Request
Package Name: perl-Crypt-CipherSaber
Short Description: Perl module implementing CipherSaber encryption
Branches: F-9 F-10 F-11 EL-5
perl-Crypt-CipherSaber-1.00-1.fc11 has been submitted as an update for Fedora 11.
perl-Crypt-CipherSaber-1.00-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Crypt-CipherSaber-1.00-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
perl-Crypt-CipherSaber-1.00-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.