Bug 497805
| Summary: | Review Request: cppcheck - A tool for static C/C++ code analysis | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Christian Krause <chkr> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | chkr, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | chkr:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.31-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-02 16:26:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Susi Lehtola
2009-04-27 11:06:21 UTC
* rpmlint: OK
rpmlint SPECS/cppcheck.spec RPMS/i386/cppcheck-* SRPMS/cppcheck-1.31-1.fc10.src.rpm
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
* naming: OK
- name matches upstream
- spec file name %{name}.spec
* License: OK
- GPLv3+ acceptable for Fedora
- license matches the actual license in the source files
- license file packaged
* spec file in English and legible: OK
* sources matches upstream: OK
- spectool -g cppcheck.spec works
- md5sum: db500cee39ceaa7379bb105046d36cce cppcheck-1.31.tar.bz2
* package compiles: OK
- rpm's %{optflags} are used correctly
- mock build successful
- koji builds for F10, F11 and F12 successful for all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1329473
https://koji.fedoraproject.org/koji/taskinfo?taskID=1329468
https://koji.fedoraproject.org/koji/taskinfo?taskID=1329463
* build requirements: OK
- the BR: gcc-c++ is not necessarily needed, since gcc-c++ is already in
the minimum build environment:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- however, it is not forbidden to add it anyway
* locales handling: OK (n/a)
* handling of static/shared objects, pkgconfig, header files, etc: OK (n/a)
* owns all directories it creates: OK
* no files listed twice in %files: OK
* permissions on files: OK
- %defattr used
- actual permissions in binary rpm OK
* clean section: OK
- rm -rf %{buildroot} used
* macro usage: OK
* code vs. content: OK
- only code and test c++ files
* large documentation in subpackage: OK (n/a)
- the test files are only 300K
* no *.la files: OK
* GUI application needs *.desktop file: OK (n/a)
* package must not own files/dirs owned by other packages: OK
* rm -rf %{buildroot} at beginning of %install: OK
* filenames UTF-8: OK
* functional test: OK
- used some of the code snippets from the test files to verify the
functionality of cppcheck
* debuginfo: OK
- debuginfo package not empty
- debuginfo actually usable
No problems found => APPROVED.
(In reply to comment #1) > * build requirements: OK > - the BR: gcc-c++ is not necessarily needed, since gcc-c++ is already in > the minimum build environment: > http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > - however, it is not forbidden to add it anyway You're right, I'll remove it. Thanks for the review. New Package CVS Request ======================= Package Name: cppcheck Short Description: A tool for static C/C++ code analysis Owners: jussilehtola Branches: EL-5 F-10 F-11 InitialCC: cvs done. cppcheck-1.31-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/cppcheck-1.31-1.fc10 cppcheck-1.31-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/cppcheck-1.31-1.fc11 cppcheck-1.31-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. cppcheck-1.31-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: cppcheck New Branches: el4 Owners: jussilehtola InitialCC: Git done (by process-git-requests). |