Bug 497991
| Summary: | Review Request: hunspell-as - Assamese hunspell dictionaries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aphukan, aphukan, fedora-package-review, notting, panemade, pnemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-29 08:14:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Caolan McNamara
2009-04-28 10:11:39 UTC
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1326189 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 4eb80c65de5c40cf0c622ff34bc28463 as_IN.oxt + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: 1) Nothing related to Fedora or its packaging but you can ask upstream to package all files only once in zip file. APPROVED. Yeah, that was my own little cock-up when trying to help out. Do either of you guys want to be the Fedora maintainer of this package, either aphukan as the also upstream maintainer, or paragn as the maintainer of the other Indic dictionaries. I can do it if not. Hello, I would like to volunteer as the maintainer of this Fedora package. Thanks a lot Caolan and Parag for your help. Amit. http://people.redhat.com/caolanm/rpms/hunspell-as-1.0.3-1.fc11.src.rpm and http://people.redhat.com/caolanm/rpms/hunspell-as.spec updated to the 1.0.3 release that takes care of the duplicate dir I don't think that aphukan has an packaging account at the moment, at least I don't see one in the packager list, so lets just set pnemade as owner, and you guys can sort it out between you at your leisure :-) New Package CVS Request ======================= Package Name: hunspell-as Short Description: Assamese hunspell dictionary Owners: pnemade Branches: F-11, devel InitialCC: caolanm cvs done. Built for F-11 and devel. |