Bug 497991 - Review Request: hunspell-as - Assamese hunspell dictionaries
Summary: Review Request: hunspell-as - Assamese hunspell dictionaries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-28 10:11 UTC by Caolan McNamara
Modified: 2009-04-29 08:14 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-29 08:14:45 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2009-04-28 10:11:39 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-as.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-as-1.0-1.fc11.src.rpm
Description: Assamese hunspell dictionaries

Comment 1 Parag AN(पराग) 2009-04-28 10:43:02 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1326189
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
4eb80c65de5c40cf0c622ff34bc28463  as_IN.oxt
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestions:
1) Nothing related to Fedora or its packaging but you can ask upstream to package all files only once in zip file. 

APPROVED.

Comment 2 Caolan McNamara 2009-04-28 11:01:33 UTC
Yeah, that was my own little cock-up when trying to help out.

Do either of you guys want to be the Fedora maintainer of this package, either aphukan as the also upstream maintainer, or paragn as the maintainer of the other Indic dictionaries. I can do it if not.

Comment 4 Amitakhya Phukan 2009-04-28 12:08:27 UTC
Hello,

I would like to volunteer as the maintainer of this Fedora package. Thanks a lot Caolan and Parag for your help.

Amit.

Comment 5 Caolan McNamara 2009-04-28 12:39:23 UTC
http://people.redhat.com/caolanm/rpms/hunspell-as-1.0.3-1.fc11.src.rpm
and
http://people.redhat.com/caolanm/rpms/hunspell-as.spec
updated to the 1.0.3 release that takes care of the duplicate dir

I don't think that aphukan has an packaging account at the moment, at least I don't see one in the packager list, so lets just set pnemade as owner, and you guys can sort it out between you at your leisure :-)

Comment 6 Caolan McNamara 2009-04-28 12:39:47 UTC
New Package CVS Request
=======================
Package Name: hunspell-as
Short Description: Assamese hunspell dictionary
Owners: pnemade
Branches: F-11, devel
InitialCC: caolanm

Comment 7 Kevin Fenzi 2009-04-29 03:21:31 UTC
cvs done.

Comment 8 Parag AN(पराग) 2009-04-29 08:14:45 UTC
Built for F-11 and devel.


Note You need to log in before you can comment on or make changes to this bug.