Bug 499483
| Summary: | Review Request: python-repoze-who-testutil - Test utilities for repoze.who-powered applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Brennan Ashton <bashton> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bashton, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bashton:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0-0.2.rc1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-28 08:05:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 468227 | ||
| Bug Blocks: | 479020 | ||
|
Description
Tom "spot" Callaway
2009-05-06 20:13:30 UTC
[pass] source files match upstream:
62ff8edc30992cd2efc42fd973252c9deddfe29b2a53b7cf903743edcb356ab8 repoze.who-testutil-1.0rc1.tar.gz
[pass] package meets naming and versioning guidelines.
[pass] specfile is properly named, is cleanly written and uses macros consistently.
[pass] dist tag is present.
[pass] build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[?] license field matches the actual license.
the license shown is BSD, but the actual license is a BSD like license is this ok. http://www.repoze.org/LICENSE.txt
[?]license is open source-compatible.
see above
[?]license text not included upstream.
setup.py in the source says that http://www.repoze.org/LICENSE.txt must be distributed with it.
[pass] latest version is being packaged.
[pass] BuildRequires are proper.
[pass] compiler flags are appropriate.
[pass] %clean is present.
package builds in mock.
(cannot do this due to dep not yet in the repos) build fine outside of mock.
[pass] package installs properly.
[pass] rpmlint is silent.
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[pass] final provides and requires are sane:
rpm -qp --requires ../RPMS/noarch/python-repoze-who-testutil-1.0-0.1.rc1.fc10.noarch.rpm
python(abi) = 2.5
python-paste-deploy
python-repoze-who
python-zope-interface
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpm -qp --provides ../RPMS/noarch/python-repoze-who-testutil-1.0-0.1.rc1.fc10.noarch.rpm
python-repoze-who-testutil = 1.0-0.1.rc1.fc10
[broken] %check is present and all tests pass:
Has upstream been informed that they do not work so that they can be fixed in future releases?
[pass] owns the directories it creates.
[pass] doesn't own any directories it shouldn't.
[pass] no duplicates in %files.
[pass] file permissions are appropriate.
[pass] code, not content.
[pass] documentation is small, so no -docs subpackage is necessary.
[pass] %docs are not necessary for the proper functioning of the package.
[pass not a GUI app] desktop files valid and installed properly.
Take a look at the license comments that I made. I think it is fine, and if it looks right to use I APPROVE.
New Package CVS Request ======================= Package Name: python-repoze-who-testutil Short Description: Test utilities for repoze.who-powered applications Owners: spot Branches: EL-5 F-10 F-11 devel InitialCC: ...and it's done. python-repoze-who-testutil-1.0-0.2.rc1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-repoze-who-testutil-1.0-0.2.rc1.fc10 python-repoze-who-testutil-1.0-0.2.rc1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-repoze-who-testutil-1.0-0.2.rc1.fc11 python-repoze-who-testutil-1.0-0.2.rc1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. python-repoze-who-testutil-1.0-0.2.rc1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |