Red Hat Bugzilla – Bug 499483
Review Request: python-repoze-who-testutil - Test utilities for repoze.who-powered applications
Last modified: 2009-05-28 04:11:36 EDT
Spec URL: http://www.auroralinux.org/people/spot/review/new/python-repoze-who-testutil.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/python-repoze-who-testutil-1.0-0.1.rc1.fc11.src.rpm
repoze.who-testutil is a repoze.who plugin which modifies repoze.who‘s
original middleware to make it easier to forge authentication, without
bypassing identification (this is, running the metadata providers).
It’s been created in order to ease testing of repoze.who-powered
applications, in a way independent of the identifiers, authenticators
and challengers used originally by your application, so that you won’t have
to update your test suite as your application grows and the authentication
[pass] source files match upstream:
[pass] package meets naming and versioning guidelines.
[pass] specfile is properly named, is cleanly written and uses macros consistently.
[pass] dist tag is present.
[pass] build root is correct.
[?] license field matches the actual license.
the license shown is BSD, but the actual license is a BSD like license is this ok. http://www.repoze.org/LICENSE.txt
[?]license is open source-compatible.
[?]license text not included upstream.
setup.py in the source says that http://www.repoze.org/LICENSE.txt must be distributed with it.
[pass] latest version is being packaged.
[pass] BuildRequires are proper.
[pass] compiler flags are appropriate.
[pass] %clean is present.
package builds in mock.
(cannot do this due to dep not yet in the repos) build fine outside of mock.
[pass] package installs properly.
[pass] rpmlint is silent.
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[pass] final provides and requires are sane:
rpm -qp --requires ../RPMS/noarch/python-repoze-who-testutil-1.0-0.1.rc1.fc10.noarch.rpm
python(abi) = 2.5
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpm -qp --provides ../RPMS/noarch/python-repoze-who-testutil-1.0-0.1.rc1.fc10.noarch.rpm
python-repoze-who-testutil = 1.0-0.1.rc1.fc10
[broken] %check is present and all tests pass:
Has upstream been informed that they do not work so that they can be fixed in future releases?
[pass] owns the directories it creates.
[pass] doesn't own any directories it shouldn't.
[pass] no duplicates in %files.
[pass] file permissions are appropriate.
[pass] code, not content.
[pass] documentation is small, so no -docs subpackage is necessary.
[pass] %docs are not necessary for the proper functioning of the package.
[pass not a GUI app] desktop files valid and installed properly.
Take a look at the license comments that I made. I think it is fine, and if it looks right to use I APPROVE.
New Package CVS Request
Package Name: python-repoze-who-testutil
Short Description: Test utilities for repoze.who-powered applications
Branches: EL-5 F-10 F-11 devel
...and it's done.
python-repoze-who-testutil-1.0-0.2.rc1.fc10 has been submitted as an update for Fedora 10.
python-repoze-who-testutil-1.0-0.2.rc1.fc11 has been submitted as an update for Fedora 11.
python-repoze-who-testutil-1.0-0.2.rc1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
python-repoze-who-testutil-1.0-0.2.rc1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.